Jrod/dit 10122 add support for c flag for defining the location of the #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new `--config` flag for the `pull` command to specify the project config file path. - Updated `initProjectConfig` to accept options for configuration. - Enhanced `executeCommand` to handle command options more effectively. - Adjusted output directory handling in JSONFormatter for improved flexibility. - Added `outDir` to output filters in shared outputs for better configuration management.
- Updated `writeFileSync` and `writeFile` functions to check for the existence of the target directory and create it recursively if it does not exist. This ensures that files can be written without errors related to missing directories.
- Moved framework processor logic to a new `json` directory for better organization. - Updated `JSONFormatter` to utilize the new `getFrameworkProcessor` function from the JSON framework. - Removed obsolete base framework and index files, streamlining the framework structure. - Introduced `BaseFramework` and `I18NextFramework` classes to handle specific framework processing. - Enhanced output directory handling in `BaseFormatter` for improved configuration management.
…-defining-the-location-of-the
- Updated `JSONFormatter` to correctly process the framework output. - Removed obsolete imports and files related to the i18next framework. - Simplified framework type handling in the framework processor. - Enhanced Zod schema for JSON output to directly specify the framework type.
marla-hoggard
requested changes
Apr 16, 2025
Contributor
marla-hoggard
left a comment
marla-hoggard
left a comment
There was a problem hiding this comment.
Everything is working great except for specifying an outDir property at the top level of the yml file. Project/variant overrides are working nicely from top and per-output specification. outDir works great if provided to a specific output. I can provide different directories for each output. and each directory is being made for me if it didn't exist.
Just can't specific an outDir at the top level of the config file. When I do that, it's being ignored and saving to the default location.
- Simplified the `format` method in `BaseFormatter` and `JSONFormatter` by removing unnecessary parameters. - Updated output directory handling in `BaseFormatter` and `AppContext` for better consistency and clarity. - Enhanced the `outDir` retrieval logic in `AppContext` to prioritize project configuration settings.
marla-hoggard
approved these changes
Apr 16, 2025
jaerod95
deleted the
jrod/dit-10122-add-support-for-c-flag-for-defining-the-location-of-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for passing in a
-c, --config <path_to_config>flag into the pull command for specifying where to find the cli config.yml.Additionally, cleans up the file structure to better match the internal architecture used within the CLI.
Adds support for new
outDirfield to specify which folder you would like to have the cli output to at the global and per output level.Finally, supports overriding project/variant configs at the output level.
Test Plan
Testing successfully completed in via:
-c ./relative/path/to/your/renamed/config.ymland ensure it reads the config correctly